GH4478: Add ExpandShortPath to resolve Windows short paths #4500
Conversation
GeertvanHorrik
changed the title
|
Added unit tests to ensure the changes are correct (and it cannot be broken in the future). |
|
@devlead anything I can do (to help) to get this merged into develop so I can start using the improved caching behavior? |
There was a problem hiding this comment.
After internal discussion, we're a bit hesitant to change the core Path classes to introduce new implicit behavior, especially given this is addressing a platform-specific edge case. We'd prefer to avoid altering base logic unless there's a broader need.
As an alternative, could you introduce a helper method in PathExtensions for this case? This could then be used i.e. in ScriptRunner.GetToolPath / GetToolPath.
|
What would be a good name for such an extension method? |
Go with |
|
PR is updated. |
- Add ExpandShortPath extension methods for FilePath and DirectoryPath - Expand short paths (e.g. PROGRA~1) to full paths for proper tool/addin location - Apply short path expansion in ScriptProcessor for installation paths - Add comprehensive tests for new functionality - fixes cake-build#4478
devlead
changed the title
devlead
force-pushed
the
pr/environment-variable-expansion
branch
from
c5ee5b0 to
4e4013c
Compare
|
@GeertvanHorrik your changes have been merged, thanks for your contribution 👍 |
2 participants
Fixes #4478
On Windows, when running from PowerShell terminal, the %temp% (and other) environment variables are expanded to a short path, causing issues when installing addins (NuGet can't find the files).
This PR resolves the short to long paths in the Path.
Added unit tests and tested this myself.
Other options I considered are when parsing the config file (when expanding), but at this stage Cake is not aware whether it's a path or not, and using path conversions can lead to unwanted side effects.