Include more detailed exception information when Exception is AggregateException

[richardgavel]

I have Tasks that will execute a Parallel.Invoke of an array of Actions. However, when an error happens, all I'll see is the "One or more errors occured". Maybe AggregateExceptions should output the message of each child exception.

[devlead]

Which version on Cake are you using, have you tried executing Cake with diagnostic verbosity?

[jnm2]

If changing the verbosity affects it, I would wonder is it ever helpful to see only the message in the special case of an AggregateException?

[devlead]

@jnm2 Issue could be that it's already within an aggregate exception because the async support. So could be an extra layer of abstraction. Whereas diagnostic gives the whole stack trace.

[jnm2]

@devlead It is an extra layer of abstraction because he is using Parallel.Invoke. I ran into the same thing with Task.WhenAll. It's sort of like if I wrote throw new AggregateException(new InvalidOperationException("foo")). I could be wrong, but wouldn't it be nice if Cake showed the messages of the InnerExceptions collection even when I'm on the default verbosity and not looking for the stack trace?

[devlead]

Well anything's possible would need to be recursive then I guess. to fetch inner inner exception messages and so on too.

[jnm2]

Yes, that's a good idea! It would be like Visual Studio's exception helper window!

throw new AggregateException(
    new AggregateException(
        new InvalidOperationException("hello")));

Makes it show:

And here's the middle one:

[patriksvensson]

I wonder if Ben Adams magic exception demystifier exists as a source package... 😄

[jnm2]

@patriksvensson benaadams/Ben.Demystifier#2 😃

[Duracell1989]

Some issue here;
I do multiple validations and combine them in 1 AggregateException.
I don't want the users to: fix 1 validation; re-run; new error; fix; re-run; etc.
That's why I want to combine them in 1 AggregateException and then I just need to throw 1 exception with all the relevant information.

[tlecomte]

Given that the code already tries to handle AggregateException here, could it be that we are just missing support for nested AggregateExceptions ? Looks like it can be handled with AggregateException.Flatten.