feat(python): add uv sync packages and allPackages options

[domenkozar]

Add support for uv sync --package and --all-packages flags:

• Add python.uv.sync.packages option for specifying individual packages
• Add python.uv.sync.allPackages option for syncing all workspace packages
• Make python.uv.sync.arguments option public (not internal)

Fixes #2140

🤖 Generated with Claude Code

[github-actions]

🔍 Suggested Reviewers

Based on git blame analysis of the changed lines, the following contributors have significant experience with the modified code:

• @bigluck - 100.0% of changed lines (1 lines)

Please consider reviewing this PR as you have authored significant portions of the code being modified. Your expertise would be valuable! 🙏

This comment was automatically generated by git-blame-auto-reviewer

Last updated: 2025-09-10T10:37:58.708Z

[claude]

Claude finished @domenkozar's task —— View job

---

Code Review Complete

I've reviewed the PR that adds uv sync packages and allPackages options to the Python module. Here's my analysis focusing on areas for improvement:

Todo List

• Read repository guidelines (CLAUDE.md)
• Analyze the Nix module implementation (python.nix)
• Review documentation changes (options.md, python.md)
• Check for potential bugs or issues
• Assess code quality and best practices
• Provide feedback on test coverage
• Submit comprehensive review

Issues & Recommendations

1. Missing Validation Logic

The implementation doesn't validate mutual exclusivity between packages and allPackages. Users could potentially set both options, which would result in confusing command line arguments:

• python.nix:166-173: Consider adding validation similar to existing poetry/uv sync assertion at python.nix:550-552

2. Test Coverage Gap

No tests exist specifically for the new packages and allPackages options:

• Current tests: /tests/python-uv-sync/ only tests basic sync functionality
• Recommendation: Add test cases for:
  • packages = ["pkg1", "pkg2"]
  • allPackages = true
  • Mutual exclusivity validation

3. Inconsistent Option Positioning

The new options are placed after allGroups in the module definition (python.nix:383-393), but the shell command construction handles them after groups (python.nix:165-173). While functional, this inconsistency could cause confusion during maintenance.

4. Shell Escaping Considerations

Package names in cfg.uv.sync.packages are shell-escaped with double quotes (python.nix:167), but no input validation exists for potentially problematic package names containing quotes or special characters.

5. Documentation Quality

The documentation correctly follows the existing pattern and references the appropriate uv flags. The descriptions are concise and accurate.

Code Quality Assessment

Strengths:

• Implementation follows established patterns in the codebase
• Proper use of lib.concatMapStrings and lib.optionalString
• Consistent option types and defaults
• Shell command construction matches existing style

Areas for improvement:

• Add input validation/assertions
• Include comprehensive test coverage
• Consider edge cases with special characters in package names

The implementation is functionally correct and follows good Nix practices, but would benefit from additional validation and test coverage before merging.

---