direnv: fix bug causing excessive reloads #1893
Merged
+68
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps reduce accidental direnv triggers.
Fixes a typo that would truncate files after opening, when we're trying to reduce unnecessary modifications.
Deploying devenv with
|
| Latest commit: |
701fa39
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cac5dbf.devenv.pages.dev |
| Branch Preview URL: | https://direnv-safe-writes.devenv.pages.dev |
Test that simply evaluating a shell does not trigger direnv to reload immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main cause was
truncate(true), which should've beentruncate(false). We ended up always writing to the files that could trigger direnv to reload.I've added a test to attempt to catch issues with direnv before we release. 60% confident it works 🙃
Fixes #1891.