Add DEVENV_CMDLINE envvar #1885
Merged
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, not sure why all those stray commits came along for the ride. I'm hoping you can squash them out if you merge it, because the diff is correct. |
…est, remove stray debugging commands and shellcheck settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWIW, I've now tested each devenv command using my exec-zsh-within-enterShell thing and at https://github.com/devenv-zsh and I think the only problem I cannot work around without modifying devenv source is this one:
This is because there is no reliable way to detect whether enterShell is being invoked by a call to "devenv shell" or from a call to "devenv processes up". This PR sets an environment variable that distinguishes these two situations from each other.
See also #36