-
Notifications
You must be signed in to change notification settings - Fork 426
Be more explicit about AI/Telemetry #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying devenv with
|
Latest commit: |
0364d77
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ac688db8.devenv.pages.dev |
Branch Preview URL: | https://telemetry-warnings.devenv.pages.dev |
@jtojnar how does this look to you? :) |
|
||
info!("Generating devenv.nix and devenv.yaml, this should take about a minute ..."); | ||
if body.is_some() { | ||
info!("Going to upload source code using `git ls-files` to https://devenv.new to analyze the environment using AI and generate devenv.nix..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“upload source code using git ls-files
“ sounds a bit like git will upload the files. Maybe something like “upload source code files from the current Git repository“, and have the details on the website in the privacy policy.
Presumably, this has different processing than the analytics whose privacy policy is on the website so it would need a separate document. Even something simple like the following would probably be fine:
- how the files are collected:
devenv generate
will collect all non-binary files in the project as listed bygit ls-files
and upload them to the server - who collects it: "Devenv corporation"
- reason for processing: building a regression test suite for AI model prompt
- how long will the data be persisted: indefinitely
- basis for processing: explicit consent – though here it might be necessary to allow people to use the service with an option to not persist their data, for the consent to be considered freely given (see Art. 7, section 4 of GDPR).
Of course, I am not a lawyer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not a lawyer, but I'm getting lawyers involved.
|
||
// Show one-time telemetry warning if not disabled and not shown before | ||
if !cli.disable_telemetry && !has_shown_telemetry_warning() { | ||
println!("\nGenerating collects anonymous usage data sent to https://devenv.new (see privacy policy) to improve generation output."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Privacy policy linked in the footer of the website, it is not really clear to me what data will be collected.
|
||
/// Checks if the telemetry warning has been shown for this project | ||
fn has_shown_telemetry_warning() -> bool { | ||
let dotfile = Path::new(".devenv/telemetry-warning-shown"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe include generate
in the name to make it clear it is specific to that feature.
7faec39
to
0364d77
Compare
Prepares release for 1.5.0