Skip to content

zlib sample build fixes for Gradle 8 or later #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

zlib sample build fixes for Gradle 8 or later #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58fc631
zlib/build.sh: Add macos-arm64 as a supported build host.
atsushieno Feb 10, 2025
6189f6d
zlib/build.gradle add explicit build task dependencies to hush Gradle8+.
atsushieno Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions samples/zlib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,27 @@ java {
withSourcesJar()
}

// Reason: Task ':javacppBuildCommand' uses this output of task ':javacppPomProperties' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
compileJava.dependsOn(tasks.named("javacppBuildParser"))
tasks.withType(WriteProperties).forEach {
it.dependsOn(tasks.named("javacppBuildParser"))
}

// Reason: Task ':javadoc' uses this output of task ':javacppPomProperties' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
tasks.named("javadoc").configure { dependsOn("javacppPomProperties") }

// Reason: Task ':javacppBuildCommand' uses this output of task ':sourcesJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
tasks.named("javacppBuildCommand").configure { dependsOn("sourcesJar") }

// Reason: Task ':compileTestJava' uses this output of task ':javacppPomProperties' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
tasks.named("compileTestJava").configure { dependsOn("javacppPomProperties") }

// Reason: Task ':javacppBuildCommand' uses this output of task ':generatePomFileForMavenJavaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
// and this does not work
tasks.named("javacppBuildCommand").configure { dependsOn("generatePomFileForMavenJavaPublication") }
// Instead, this should make it work:
tasks.named("javacppBuildCommand").configure { dependsOn(tasks.withType(GenerateMavenPom)) }

def pomClosure = {
name = 'JavaCPP Presets for zlib'
delegate.description = 'Sample project for the build plugin of Gradle JavaCPP'
Expand Down
5 changes: 5 additions & 0 deletions samples/zlib/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ case $PLATFORM in
make -j $MAKEJ
make install
;;
macosx-arm64)
./configure --prefix=.. --static
make -j $MAKEJ
make install
;;
macosx-x86_64)
./configure --prefix=.. --static
make -j $MAKEJ
Expand Down
Loading