Skip to content

feat(go-nats): remove error channel and indexedStreamReader #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

feat(go-nats): remove error channel and indexedStreamReader #253

merged 1 commit into from
Aug 20, 2024

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Aug 20, 2024 •
edited
Loading

  • Remove usage of .errors channel removed in latest wRPC-over-NATS versions
  • Remove indexedStreamReader abstraction, instead just use streamReader
  • Count references to nested subscriptions and unsub only once all of them are dropped (possibly fixes issue originally reported in fix(go): Closing nats subscriptions #214, still getting there)

cc @lxfontes

@rvolosatovs rvolosatovs enabled auto-merge August 20, 2024 14:25
@rvolosatovs rvolosatovs added this pull request to the merge queue Aug 20, 2024
Merged via the queue into bytecodealliance:main with commit 173426e Aug 20, 2024
25 checks passed
@rvolosatovs rvolosatovs deleted the feat/go-nats-transport-sync branch August 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rvolosatovs