Fix benchmark running on CI #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make sure the `main` branch is available to checkout * Fix collection of tests (currently zero benchmarks are run)
Robbepop
approved these changes
Jun 29, 2020
Collaborator
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
LGTM
Especially the new collect_test_files looks clean, thanks!
When fixing the benchmarks I didn't know whether the testsuite directory is actually required to be queried for benchmarks or not - looks like this wasn't the case according to this PR. Cannot say anything about the .github/workflow changes.
Member
Author
fitzgen
pushed a commit
to fitzgen/wasm-tools
that referenced
this pull request
Oct 21, 2020
Looks like the spec tests want a validation error, not a parse error, when the lane is out of bounds. Closes bytecodealliance#35
dhil
pushed a commit
to dhil/wasm-tools
that referenced
this pull request
Oct 19, 2022
* Fix resume_throw argument order
dhil
added a commit
to dhil/wasm-tools
that referenced
this pull request
Nov 28, 2023
Merge with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch is available to checkout