Skip to content

wamr-test-suites/test_wamr.sh: add an option to specify wamrc binary #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2024
Merged

wamr-test-suites/test_wamr.sh: add an option to specify wamrc binary #3635

merged 2 commits into from
Jul 18, 2024

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Jul 17, 2024

No description provided.

yamt added 2 commits July 17, 2024 10:30
@yamt
spec-test-script/all.py: Add the --aot-compiler option
e907056 
To be consistent with wasi_test.py and runtest.py.

Probably this is not strictly necessary as runtest.py
uses the WAMRC_CMD environment variable.
@yamt
wamr-test-suites/test_wamr.sh: add an option to specify wamrc binary
342c563
@HongxiaWangSSSS
Copy link
Contributor

Hi yamt-san,
I'd like to know why use external wamrc in ci? Sometimes using the wrong version of wamrc may also cause the test to fail, like aot in different formats, unsolved issues.
Maybe the wamrc generated using the current version better reflects the accuracy of the test.
If it is about the xtensa platform, I prefer according the platform build different wamrc in the current wamr.

@yamt
Copy link
Collaborator Author

yamt commented Jul 17, 2024

I'd like to know why use external wamrc in ci?

i occasionally run this script locally and i often have a wamrc binary to use.

@yamt yamt mentioned this pull request Jul 17, 2024
Closed
wenyongh
wenyongh approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lum1n0us
lum1n0us approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 9f637e6 into bytecodealliance:main Jul 18, 2024
378 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

@lum1n0us lum1n0us lum1n0us approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamt @HongxiaWangSSSS @wenyongh @lum1n0us