Skip to content

Conversation

lum1n0us
Copy link
Collaborator

  • UBsan detected: unsigned integer overflow: 2684354559 * 2 cannot be represented in type 'uint32' (aka 'unsigned int')
  • adjust compilation options

@lum1n0us lum1n0us force-pushed the fix/fuzz_issue_adjust_table_max_size branch from 7cb3e2b to d637049 Compare June 13, 2024 02:32
@lum1n0us
Copy link
Collaborator Author

Shall I upload the wasm binary file as a regression?

-fsanitize=address,undefined
# reference: https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync this configuration up with config-common.cmake?

@lum1n0us lum1n0us mentioned this pull request Jun 13, 2024
@lum1n0us lum1n0us force-pushed the fix/fuzz_issue_adjust_table_max_size branch from d637049 to 9c270e9 Compare June 13, 2024 02:49
@lum1n0us lum1n0us force-pushed the fix/fuzz_issue_adjust_table_max_size branch 2 times, most recently from 06495da to 4aa015d Compare June 13, 2024 04:43
@lum1n0us lum1n0us changed the title Fix an unsigned int overflow issue Fix several fuzzing issues Jun 13, 2024
@lum1n0us lum1n0us mentioned this pull request Jun 13, 2024
@lum1n0us lum1n0us force-pushed the fix/fuzz_issue_adjust_table_max_size branch 2 times, most recently from 767c8b6 to 0c906eb Compare June 13, 2024 05:14
This was referenced Jun 13, 2024
@lum1n0us lum1n0us marked this pull request as ready for review June 13, 2024 05:52
@lum1n0us lum1n0us force-pushed the fix/fuzz_issue_adjust_table_max_size branch from 0c906eb to 74834ee Compare June 13, 2024 07:09
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- #69574 UBsan detected an unsigned int overflow issue:
  ```
  unsigned integer overflow: 2684354559 * 2 cannot be represented in type 'uint32' (aka 'unsigned int')
  ```
- #69576 ASan detected an stack overflow issue:
  ```
  multi-byte-read-stack-buffer-overflow
  ```
- #69577 ASan detected an assertions about `load_memory_info()`
- #69579 ASan OOM
- adjust compilation options
@lum1n0us lum1n0us force-pushed the fix/fuzz_issue_adjust_table_max_size branch from 74834ee to 9481a4b Compare June 13, 2024 07:29
@wenyongh wenyongh merged commit 40c41d5 into bytecodealliance:main Jun 13, 2024
@lum1n0us lum1n0us deleted the fix/fuzz_issue_adjust_table_max_size branch November 20, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants