aot compiler: Fix the length type passed to aot_memmove/aot_memset #3378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
changed the title
loganek
reviewed
Apr 30, 2024
| call_aot_memmove = comp_ctx->is_indirect_mode || comp_ctx->is_jit_mode; | ||
| if (call_aot_memmove) { | ||
| LLVMTypeRef param_types[3], ret_type, func_type, func_ptr_type; | ||
| LLVMValueRef func, params[3]; | ||
|
|
||
| param_types[0] = INT8_PTR_TYPE; | ||
| param_types[1] = INT8_PTR_TYPE; | ||
| param_types[2] = I32_TYPE; | ||
| param_types[2] = INTPTR_T_TYPE; /* int32 for 32-bit, int64 for 64-bit */ |
There was a problem hiding this comment.
Could we perhaps define SIZE_T_TYPE (or MEM_OFFSET_T_TYPE) instead? Even though it will (almost) always have the same value as INTPTR_T_TYPE, semantically pointer and size are different so the code would probably be slightly easier to read and maintain.
There was a problem hiding this comment.
OK, updated to use SIZE_T_TYPE instead. I didn't add MEM_OFFSET_T_TYPE since it cannot be decided by the target bit width, e.g. in 64-bit target, the memory may be 32-bit or 64-bit. Or it seems we had to define MEM_OFFSET_T_TYPE(memory) like macro to set its type according to the memory's type.
wrong link? |
yamt
reviewed
Apr 30, 2024
| /* zero extend to uint64 if the target is 64-bit */ | ||
| len = LLVMBuildZExt(comp_ctx->builder, len, I64_TYPE, "len64"); | ||
| if (!len) { | ||
| aot_set_last_error("llvm build bitcast failed."); |
| /* zero extend to uint64 if the target is 64-bit */ | ||
| len = LLVMBuildZExt(comp_ctx->builder, len, I64_TYPE, "len64"); | ||
| if (!len) { | ||
| aot_set_last_error("llvm build bitcast failed."); |
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 1, 2024
…ytecodealliance#3378) The current length type of aot_memmove/aot_memset is size_t, and on a 64 bit host it is uint64, while what the aot code passes to it is uint32, this might lead to unexpected behavior. ps. bytecodealliance#3376.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 2, 2024
…ytecodealliance#3378) The current length type of aot_memmove/aot_memset is size_t, and on a 64 bit host it is uint64, while what the aot code passes to it is uint32, this might lead to unexpected behavior. ps. bytecodealliance#3376. Signed-off-by: victoryang00 <[email protected]>
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#3378) The current length type of aot_memmove/aot_memset is size_t, and on a 64 bit host it is uint64, while what the aot code passes to it is uint32, this might lead to unexpected behavior. ps. bytecodealliance#3376. Signed-off-by: victoryang00 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current length type of aot_memmove/aot_memset is size_t, and on
a 64 bit host it is uint64, while what the aot code passes to it is uint32,
this might lead to unexpected behavior.
ps. #3375.