Skip to content

Conversation

wenyongh
Copy link
Contributor

No description provided.

@wenyongh wenyongh merged commit 2349df1 into bytecodealliance:main Feb 27, 2024
@wenyongh wenyongh deleted the fix_gc_ref_func_check branch February 29, 2024 01:10
@wenyongh
Copy link
Contributor Author

wenyongh commented Mar 1, 2024

Fixed with #3181.

@wenyongh
Copy link
Contributor Author

wenyongh commented Mar 1, 2024

The root cause is when GC is enabled, the type of table segment can be (ref func) besides with funcref, while the original code only checks funcref type.

vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
The current code assumes that the element type of table segment can
be `funcref` only, but when GC is enabled, the type can be `(ref func)`
also.

Fixes bytecodealliance#3168.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant