wamr-ide: modify Dockerfile to update base image version and fix build bug #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
reviewed
Mar 27, 2023
| RUN git clone -b main --depth=1 https://github.com/bytecodealliance/wasm-micro-runtime.git | ||
| RUN git clone -b main --depth=1 https://github.com/bytecodealliance/wasm-micro-runtime.git \ | ||
| && cd wasm-micro-runtime/build-scripts \ | ||
| && pip3 install --user -r requirements.txt |
There was a problem hiding this comment.
just my little concern, does it work well without installing pip, ninja and CCache?
There was a problem hiding this comment.
have installed in line:15
|
BTW, please lint Dockerfiles with (https://github.com/hadolint/hadolint). |
lum1n0us
reviewed
Mar 28, 2023
| && apt-get -y install make --no-install-recommends | ||
| RUN apt update \ | ||
| && apt-get -y install ccache ninja-build make cmake python3-pip --no-install-recommends \ | ||
| && pip3 install requests |
There was a problem hiding this comment.
requirements.txt includes requests. might don't need L16.
NingW101
force-pushed
the
fix-docker-build-bug
branch
from
d0898d2 to
963efaa
Compare
|
LGTM |
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.