Enable gcc-4.8 compilation #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
force-pushed
the
loganek/gcc4.8
branch
3 times, most recently
from
bb48889 to
7bb7d93
Compare
|
why do you care that old gcc? (just a curious question) |
loganek
force-pushed
the
loganek/gcc4.8
branch
from
7bb7d93 to
d922ff3
Compare
Unfortunately some of the toolchains still use that version. |
loganek
force-pushed
the
loganek/gcc4.8
branch
2 times, most recently
from
c9051fd to
99c2701
Compare
loganek
force-pushed
the
loganek/gcc4.8
branch
from
99c2701 to
66ac3d9
Compare
loganek
commented
Feb 1, 2023
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/numeric_limits.h
Outdated
Show resolved
Hide resolved
loganek
force-pushed
the
loganek/gcc4.8
branch
from
41bbb63 to
8b1b7f5
Compare
… it is no longer in use
loganek
force-pushed
the
loganek/gcc4.8
branch
2 times, most recently
from
8a11dc2 to
b33a73a
Compare
wenyongh
pushed a commit
that referenced
this pull request
Apr 6, 2023
In #1928 we added support for GCC 4.8 but we don't continuously test if it's working. This PR added a GitHub actions job to test compilation on GCC 4.8 for interpreters and Fast JIT (LLVM JIT/AOT might be added in the future). The compilation is done using ubuntu 14.04 image as that's the simplest way to get GCC 4.8 compiler. The job only compiles the code but does not run any tests.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
In bytecodealliance#1928 we added support for GCC 4.8 but we don't continuously test if it's working. This PR added a GitHub actions job to test compilation on GCC 4.8 for interpreters and Fast JIT (LLVM JIT/AOT might be added in the future). The compilation is done using ubuntu 14.04 image as that's the simplest way to get GCC 4.8 compiler. The job only compiles the code but does not run any tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, I'll think of having a CI job for gcc4.8 too