Skip to content

Fix: Prevent crash in LruBitmapPool.put() on recycled bitmap #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent crash in LruBitmapPool.put() on recycled bitmap #5523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions library/src/main/java/com/bumptech/glide/load/engine/bitmap_recycle/LruBitmapPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,11 @@ public synchronized void setSizeMultiplier(float sizeMultiplier) {

@Override
public synchronized void put(Bitmap bitmap) {
if (bitmap == null) {
throw new NullPointerException("Bitmap must not be null");
}
if (bitmap.isRecycled()) {
throw new IllegalStateException("Cannot pool recycled bitmap");
if (bitmap == null || bitmap.isRecycled()) {
if (Log.isLoggable(TAG, Log.WARN)) {
Log.w(TAG, "Ignored recycled bitmap passed to pool");
}
return;
}
if (!bitmap.isMutable()
|| strategy.getSize(bitmap) > maxSize
Expand Down
Loading