Skip to content

Log failure to close and remove build directory #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Log failure to close and remove build directory #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/builder/local_build_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package builder

import (
"context"
"log"
"os"
"sync"
"time"
Expand Down Expand Up @@ -114,7 +115,11 @@ func (be *localBuildExecutor) CheckReadiness(ctx context.Context) error {
if err != nil {
return util.StatusWrap(err, "Failed to get build directory")
}
defer buildDirectory.Close()
defer func() {
if err := buildDirectory.Close(); err != nil {
log.Printf("Failed to close build directory %s: %s", buildDirectoryPath.GetUNIXString(), err)
}
}()

// Create a useless directory inside the build directory. The
// runner will validate that it exists.
Expand Down Expand Up @@ -166,6 +171,7 @@ func (be *localBuildExecutor) Execute(ctx context.Context, filePool re_filesyste
attachErrorToExecuteResponse(
response,
util.StatusWrap(err, "Failed to close build directory"))
log.Printf("Failed to close build directory %s: %s", buildDirectoryPath.GetUNIXString(), err)
}
}()

Expand Down
Loading