Skip to content

Add net6.0 target framework for Bugsnag and Bugsnag.AspNet.Core #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
+20 −37
Merged

Add net6.0 target framework for Bugsnag and Bugsnag.AspNet.Core #179

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56a9d20
add net6.0 TFM for Bugsnag and Bugsnag.AspNet.Core
yousif-bugsnag Mar 24, 2025
00e0cb8
remove DisableImplicitFrameworkReferences and tidy up project files
yousif-bugsnag Mar 24, 2025
e5f5937
Fix test dependencies
yousif-bugsnag Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Bugsnag.AspNet.Core/Bugsnag.AspNet.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,19 @@
<PackageId>Bugsnag.AspNet.Core</PackageId>
<Title>Bugsnag .NET ASP.NET Core Notifier</Title>
<Description>The Bugsnag Notifier for ASP.NET Core gives you instant notification of exceptions thrown from your ASP.NET Core applications. Any uncaught exceptions will trigger a notification to be sent to your Bugsnag project.</Description>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<SignAssembly>false</SignAssembly>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Bugsnag\Bugsnag.csproj" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />
<PackageReference Include="Microsoft.Extensions.DiagnosticAdapter" Version="3.1.32" />
</ItemGroup>
<ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
<FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2" />
<PackageReference Include="Microsoft.Extensions.DiagnosticAdapter" Version="3.1.32" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="8.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Diagnostics.Abstractions" Version="2.3.0" />
<PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.3.0" />
Expand Down
10 changes: 3 additions & 7 deletions src/Bugsnag.AspNet.Mvc/Bugsnag.AspNet.Mvc.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,10 @@
<ItemGroup>
<ProjectReference Include="..\Bugsnag.AspNet\Bugsnag.AspNet.csproj" />
<ProjectReference Include="..\Bugsnag\Bugsnag.csproj" />
</ItemGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="System.Configuration" />

<Reference Include="System.Web" />
<Reference Include="System.Web.Abstractions" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'net462'">


<PackageReference Include="Microsoft.AspNet.Mvc" Version="5.0.0" />
</ItemGroup>
</Project>
5 changes: 0 additions & 5 deletions src/Bugsnag.AspNet.WebApi/Bugsnag.AspNet.WebApi.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
<Description>The Bugsnag Notifier for ASP.NET WebApi gives you instant notification of exceptions thrown from your ASP.NET WebApi applications. Any uncaught exceptions will trigger a notification to be sent to your Bugsnag project.</Description>
<TargetFrameworks>net462</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Configuration" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Bugsnag\Bugsnag.csproj" />
<ProjectReference Include="..\Bugsnag.ConfigurationSection\Bugsnag.ConfigurationSection.csproj" />
Expand Down
3 changes: 0 additions & 3 deletions src/Bugsnag.AspNet/Bugsnag.AspNet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@
<ProjectReference Include="..\Bugsnag.ConfigurationSection\Bugsnag.ConfigurationSection.csproj" />
</ItemGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Configuration" />
<Reference Include="System.Web" />
<Reference Include="System.Web.Abstractions" />
</ItemGroup>
</Project>
2 changes: 0 additions & 2 deletions src/Bugsnag.ConfigurationSection/Bugsnag.ConfigurationSection.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
<ProjectReference Include="..\Bugsnag\Bugsnag.csproj" />
</ItemGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Configuration" />
</ItemGroup>
</Project>
14 changes: 1 addition & 13 deletions src/Bugsnag/Bugsnag.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,9 @@
<PackageId>Bugsnag</PackageId>
<Title>Bugsnag .NET Notifier</Title>
<Description>The Bugsnag Notifier for .NET gives you instant notification of exceptions thrown from your .NET applications. Any uncaught exceptions will trigger a notification to be sent to your Bugsnag project.</Description>
<TargetFrameworks>net462;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net462;netstandard2.0;net6.0</TargetFrameworks>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Runtime.Serialization" />
<Reference Include="System.Xml" />
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Net.Http" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
<PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
<PackageReference Include="System.Diagnostics.StackTrace" Version="4.3.0" />
<PackageReference Include="System.Runtime.Serialization.Primitives" Version="4.3.0" />
<PackageReference Include="System.Threading.Thread" Version="4.3.0" />
</ItemGroup>
</Project>
2 changes: 2 additions & 0 deletions src/Bugsnag/UnhandledException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ private void TaskScheduler_UnobservedTaskException(object sender, UnobservedTask
HandleEvent(e.Exception as Exception, _unobservedTerminates && !e.Observed);
}

#if NET462 || NETSTANDARD2_0
[HandleProcessCorruptedStateExceptions]
#endif
private void CurrentDomain_UnhandledException(object sender, UnhandledExceptionEventArgs e)
{
HandleEvent(e.ExceptionObject as Exception, e.IsTerminating);
Expand Down
3 changes: 1 addition & 2 deletions src/Directory.build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project>
<Project>
<PropertyGroup>
<Authors>snmaynard kattrali martin308</Authors>
<Version></Version>
Expand All @@ -7,7 +7,6 @@
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageProjectUrl>https://github.com/bugsnag/bugsnag-dotnet</PackageProjectUrl>
<PackageIcon>bugsnag.png</PackageIcon>
<DisableImplicitFrameworkReferences Condition="'$(TargetFramework)' != 'netstandard1.3' AND '$(TargetFramework)' != 'netstandard2.0'">true</DisableImplicitFrameworkReferences>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LangVersion>7.1</LangVersion>
<NoWarn>1591</NoWarn>
Expand Down