Report errors in `file` input/output operations #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bugdea1er merged 2 commits into main from file-io

Jan 3, 2025

Owner

bugdea1er commented Dec 31, 2024 •

edited

Loading

Methods file::read, file::write and file::append did not report errors due to use of <fstream> C++ API

Reimplement these methods via system calls to actually check for system errors and throw proper std::filesystem::filesystem_error

bugdea1er force-pushed the file-io branch 3 times, most recently from 8314a68 to e43252e Compare

December 31, 2024 16:52

bgs99 reviewed

View reviewed changes

src/file.cpp Outdated Show resolved Hide resolved

bugdea1er force-pushed the file-io branch 2 times, most recently from d5214ed to e06b8b0 Compare

January 1, 2025 16:37

bugdea1er marked this pull request as ready for review

January 1, 2025 21:32

bugdea1er commented

View reviewed changes

src/file.cpp Outdated Show resolved Hide resolved

bugdea1er commented

View reviewed changes

src/file.cpp Outdated Show resolved Hide resolved

bugdea1er commented

View reviewed changes

src/file.cpp Outdated Show resolved Hide resolved

bugdea1er force-pushed the file-io branch from a2c2f60 to 41f5d46 Compare

January 2, 2025 21:24

bugdea1er commented

View reviewed changes

src/file.cpp Outdated Show resolved Hide resolved

bugdea1er commented

View reviewed changes

src/file.cpp Outdated Show resolved Hide resolved

bugdea1er force-pushed the file-io branch from dc6887f to 4fa548b Compare

January 3, 2025 16:13


          Throw std::filesystem::filesystem_error from file::read, `file::w…

6b6577a

…rite` and `file::append`

bugdea1er force-pushed the file-io branch from 4fa548b to 6b6577a Compare

January 3, 2025 16:13


          Stylefixes

118c3fb

Owner Author

bugdea1er commented Jan 3, 2025

Moved all other optimizations to #139

bugdea1er merged commit 96b5de6 into main

9 checks passed

bugdea1er deleted the file-io branch

January 3, 2025 16:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet