Fix unreliable asset generation #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache defaults to true use-latest is not a valid argument in v5
rodaine
approved these changes
Jan 23, 2025
pkwarren
approved these changes
Jan 23, 2025
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to fix the symptoms described in the following two issues:
It seems the goreleaser action that was triggered by the 1.2.1 tag thought that the current tag was 1.2.1.SNAPSHOT.0
Source: https://github.com/bufbuild/protoc-gen-validate/actions/runs/12916704001/job/36021453853#step:5:21
Basically we ended up with two tags pointing at the same commit and goreleaser picked one: goreleaser/goreleaser#4134
We were unnecessarily increasing the likelihood of that happening by force fetching all tags (which is unnecessary because we will already have the intended tag fetched that triggered the push), so I removed that step here: 87dc0be
Additionally, I don't think there is any value in having snapshot tags at all so I deleted the entire version bump workflow here: 79a4a4f
Furthermore, we had goreleaser configured to publish drafts, which doesn't make sense if we want to initiate release from the GitHub UI (which I think we do and is similer/easier) so I deleted all the extra config here: 56f26d0
The default config is the right thing for us.
Finally there were some settings in setup-go we had configured that have no effect now, so I removed them: 33528d7