Skip to content

Default Note() channel was overriding the channel from other places #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 1 commit into from
Closed

Default Note() channel was overriding the channel from other places #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions mingus/containers/note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class Note(object):
name = 'C'
octave = 4
dynamics = {}
channel = 1
velocity = 64

def __init__(self, name='C', octave=4, dynamics={}):
Expand All @@ -60,13 +59,13 @@ def __init__(self, name='C', octave=4, dynamics={}):
raise NoteFormatError("Don't know what to do with name object: "
"'%s'" % name)


def set_channel(self, channel):
self.channel = channel

def set_velocity(self, velocity):
self.velocity = velocity

def set_note(self, name='C', octave=4, dynamics={}):
"""Set the note to name in octave with dynamics.

Expand Down Expand Up @@ -250,7 +249,7 @@ def from_shorthand(self, shorthand):
def __int__(self):
"""Return the current octave multiplied by twelve and add
notes.note_to_int to it.

This means a C-0 returns 0, C-1 returns 12, etc. This method allows
you to use int() on Notes.
"""
Expand Down Expand Up @@ -298,4 +297,3 @@ def __ge__(self, other):
def __repr__(self):
"""Return a helpful representation for printing Note classes."""
return "'%s-%d'" % (self.name, self.octave)