Skip to content

SCNotifications need updating #253

@vinsworldcom

Description

@vinsworldcom

Discovered in #251 there are some SCNotifications that are missing returns and some are missing completely. The list:

A quick glance between the PythonScript 'Scintilla.h' (PythonScript\PythonScript\src\Scintilla.h), the Scintilla docs and the 'ScintillaWrapper.cpp' file yields this:

			case SCN_CHARADDED:
				params["ch"] = notifyCode->ch;
+				params["characterSource"] = notifyCode->characterSource;
				break;

			case SCN_USERLISTSELECTION:
+				params["ch"] = notifyCode->ch;
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
				params["text"] = notifyCode->text;
				params["listType"] = notifyCode->listType;
                params["position"] = notifyCode->position;
				break;

			case SCN_AUTOCSELECTION:
+				params["ch"] = notifyCode->ch;
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
				params["text"] = notifyCode->text;
                params["position"] = notifyCode->position;
				break;

+			case SCN_AUTOCSELECTIONCHANGE:
+				params["position"] = notifyCode->position;
+				params["text"] = notifyCode->text;
+				params["listType"] = notifyCode->listType;

+			case SCN_AUTOCCOMPLETED:
+				params["listCompletionMethod"] = notifyCode->listCompletionMethod;
+				break;

Cheers.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions