Skip to content

[wip] improve lua performance #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bomgar wants to merge 1 commit into from
Closed

[wip] improve lua performance #2

bomgar wants to merge 1 commit into from

Conversation

@bomgar
Copy link
Member

@bomgar bomgar commented Jul 8, 2017 •
edited
Loading

  1. I don't like, that lua is allocated although it is not needed if no filter is specifier
  2. I don't like that other variables survive the log entry.

@bomgar
Copy link
Member Author

bomgar commented Jul 8, 2017

@mriehl maybe you have a better solution

@bomgar bomgar requested a review from mriehl July 8, 2017 14:51
@bomgar
Copy link
Member Author

bomgar commented Jul 9, 2017

i don't like that the state needs to be cleaned instead of being recreated. I will leave this as it is.

tomaka/hlua#147 this should at least help with the performance.

@bomgar bomgar closed this Jul 9, 2017
@bomgar bomgar deleted the lua-performance branch September 13, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mriehl mriehl Awaiting requested review from mriehl

Assignees

@mriehl mriehl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bomgar @mriehl