Potential fix for code scanning alert no. 15: Implicit narrowing conversion in compound assignment #9146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion in compound assignment Fixes a bug where sums were accidentally cast down to int. Looking at the usages it seems like it's unlikely it was ever a problem in practice because the sums calculated look like they would never have been bigger than max int. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
@jamesemery code scanning found a real bug. It's a miracle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/broadinstitute/gatk/security/code-scanning/15
To fix the problem, we need to change the type of the
totalvariable frominttolong. This will ensure that the sum of thelongvalues in the array is correctly stored without any implicit narrowing conversion. The change should be made in thesum(final long[] x)method in theMathUtilsclass.Suggested fixes powered by Copilot Autofix. Review carefully before merging.