rb_mysql_result_free_result is now executed if the result is 0 rows. #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are 0 rows in the result, the condition to load the cache from the beginning (lastRowProcessed == numberOfRows) is met, and the else route is not entered. To resolve this, the else route is always entered first.
|
Confirmed your repro in #1398 and this fix! Really appreciate your clean and clear fix! |
Closed
skipkayhil
added a commit
to skipkayhil/mysql2
that referenced
this pull request
Sep 26, 2025
…0 rows. (brianmario#1399)" This reverts commit 3adb531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1398
When there are 0 rows in the result, the condition to load the cache from the beginning (
lastRowProcessed == numberOfRows) is met, and the else route is not entered. Because of this,rb_mysql_result_free_resultis not called.To resolve this, the else route is always entered first.