fix "The "chunk" argument must be one of type string or Buffer." error #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @conartist6 |
KalleV
added a commit
to LabShare-Archive/services-auth
that referenced
this pull request
Aug 30, 2018
mnkhouri
added a commit
to depcheck/depcheck
that referenced
this pull request
Sep 3, 2018
CI is currently using npm@3 in AppVeyor, and npm@3 in Travis's Node v6 env (because npm@3 is bundled with Node v6). This has caused an issue in CI, because ["[email protected]" was installed](https://ci.appveyor.com/project/lijunle/depcheck/build/519/job/5c7qv724u4hqtoh4#L447) and broke builds [due to this issue](brianc/node-deprecate#7), even though "[email protected]" is specified in our package-lock.json. npm@5 is the first version that uses package-lock.json by default, but I think there's no harm in just using npm@6.
|
I think the root cause is in #6, in this pr, the signature of |
mnkhouri
added a commit
to depcheck/depcheck
that referenced
this pull request
Sep 8, 2018
CI is currently using npm@3 in AppVeyor, and npm@3 in Travis's Node v6 env (because npm@3 is bundled with Node v6). This has caused an issue in CI, because ["[email protected]" was installed](https://ci.appveyor.com/project/lijunle/depcheck/build/519/job/5c7qv724u4hqtoh4#L447) and broke builds [due to this issue](brianc/node-deprecate#7), even though "[email protected]" is specified in our package-lock.json. npm@5 is the first version that uses package-lock.json by default, but I think there's no harm in just using npm@6.
SpringStar-dev
added a commit
to SpringStar-dev/depcheck
that referenced
this pull request
Aug 29, 2025
CI is currently using npm@3 in AppVeyor, and npm@3 in Travis's Node v6 env (because npm@3 is bundled with Node v6). This has caused an issue in CI, because ["[email protected]" was installed](https://ci.appveyor.com/project/lijunle/depcheck/build/519/job/5c7qv724u4hqtoh4#L447) and broke builds [due to this issue](brianc/node-deprecate#7), even though "[email protected]" is specified in our package-lock.json. npm@5 is the first version that uses package-lock.json by default, but I think there's no harm in just using npm@6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.