Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Block site-level Facebook tracking #14446

@lukemulks

Description

@lukemulks

Description

We currently block 3rd party facebook graph and tracking requests via https://github.com/brave/adblock-lists/blob/master/brave-unbreak.txt#L43
https://github.com/brave/adblock-lists/blob/master/brave-unbreak.txt#L44
https://github.com/brave/adblock-lists/blob/master/brave-unbreak.txt#L45

However, on some domains, such as: https://www.dodocase.com/ - certain functional facebook sdk requests are allowed to be made, which then allow for the invocation of the facebook tracking pixel.

example: https://connect.facebook.net/en_GB/sdk.js
example: https://connect.facebook.net/en_US/fbds.js

allowing for:
https://www.facebook.com/tr/?id=384396585036633&ev=PixelInitialized&dl=https%3A%2F%2Fwww.dodocase.com%2F&rl=https%3A%2F%2Fwww.dodocase.com&if=false&ts=1529367847202

and:

https://staticxx.facebook.com/connect/xd_arbiter/r/qMnGlIs-JNW.js?version=42

Steps to Reproduce

  1. go to https://www.dodocase.com with the network panel in dev tools open
  2. observe the facebook requests being made

Actual result:

Expected result:

Reproduces how often:

100% on certain domains with the fb js sdk implemented

Brave Version

about:brave info:

Brave: 0.22.810
V8: 6.7.288.43
rev: 8f30eeb
Muon: 7.0.6
OS Release: 10.0.16299
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.71

Reproducible on current live release:

Yes

Additional Information

At the time the original filter rules were created, there were concerns regarding being too aggressive, and blocking requests that would break functionality. That's why the sdk requests were not blocked, and third-party filter rules were made.

We should revisit this approach, and update to block the facebook.com/tr tracking pixel from firing.
cc: @diracdeltas @BrendanEich @snyderp

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions