Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Block .onion requests or transplant them to tabs with Tor enabled #14431

@riastradh-brave

Description

@riastradh-brave

Test Cases

Please run through the test cases in the following PR: 855c5a4

Original Reported Issue

If a user enters https://nyttips4bmquxfzw.onion/ into the URL bar of a tab without Tor, they probably actually wanted to reach it over Tor, and probably didn't want to notify their unfriendly neighbourhood DNS server that they're about to leak something in exchange for a name resolution error page.

  • For .onion sites entered into the URL bar, we should consider either
    1. automatically transplanting them into a private tab with Tor enabled, or
    2. notifying them that the tab is not using Tor and can't reach onion services.
  • For .onion sites retrieved during page load, we should consider blocking them immediately.
    • Consider, for example, testing a locally served version of an onion site, which has secret links to other onion sites. (Old-style short onion names like the NYT Tips one above are not kept secret by the Tor network, but the next generation onion names are kept secret.)

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions