-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Description
Description
When following the build instructions, npm run init
will fail with the following error message (after downloading the largest part of the Chromium source finished):
The same name "src/third_party/android_sdk/public" appears multiple times in the deps section
Steps to Reproduce
git clone https://github.com/brave/brave-browser
1b. (Apply patches, see bottom of issue report)cd brave-browser
npm run init
Actual result:
Fails with the following error message:
The same name "src/third_party/android_sdk/public" appears multiple times in the deps section
Expected result:
The sync should finish (afaik) without errors.
Reproduces how often:
Every time
Brave version (brave://version info)
(Doesn't apply, building issue. The cloned brave-browser repository is at commit e1e3dc0)
Reproducible on current release:
See above
Additional Information
My host OS is Arch Linux, so python3 is the default. Therefore, I wrote two different patches to make the build system use python2. The issue exists with both of those patches, unfortunately I don't have a OS nearby that uses python2 by default and bash aliases don't work because of subshells. However, I doubt that there is any difference between using those patches and running it on a python2-default OS.
depot-tools-python2_v1.diff.txt
depot-tools-python2_v2.diff.txt