Use only the 2 smallest sugarcoat resources #740
Conversation
|
lgtm. @ShivanKaul is still on PTO for a bit so i think might be best to merge w/o waiting for the additional review, if his review isn't strictly needed |
| ||assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_AudienceManagement.min.js$script,important,domain=virginmobile.ca,redirect-url=https://pcdn.brave.com/sugarcoat/async-sugarcoat-d357b361eae50395667a4c91732192fd.js | ||
| ||quantcast.mgr.consensu.org/tcfv2/cmp2.js?referer=einthusan.tv$script,important,domain=einthusan.tv,redirect-url=https://pcdn.brave.com/sugarcoat/async-sugarcoat-968076ccecd06aaae1ffcb1e3d26399f.js | ||
| ||googletagservices.com/tag/js/gpt.js$script,important,domain=downdetector.com,redirect-url=https://pcdn.brave.com/sugarcoat/async-sugarcoat-a8badcefe5197e12ea29f0f5d0db1cc9.js | ||
| ||assets.adobedtm.com/extensions/EPbde2f7ca14e540399dcc1f8208860b7b/AppMeasurement_Module_AudienceManagement.min.js$script,important,domain=bmw.com.au,redirect=async-sugarcoat-4c15a27239807d1629304fcae3cf6ce3.js |
There was a problem hiding this comment.
I believe the redirect filter option does not take in the file extension (.js), so the filter option would just be redirect=async-sugarcoat-4c15a27239807d1629304fcae3cf6ce3. However, I think these 2 rules in particular are obsolete: brave/brave-browser#18542 (comment)
I have a local PR that adds a few new ones (10 rules), I can update that to be just 2 rules. I thought we were waiting for brave/brave-core#10994 to be closed?
There was a problem hiding this comment.
I believe the redirect filter option does not take in the file extension (.js)
For full compatibility with uBO, redirect accepts the version of the redirect resource with the .js extension or without. Although you're correct in that it's usually omitted.
I thought we were waiting for brave/brave-core#10994 to be closed?
That PR is still being reviewed; we'd like to get some demo working sooner so as small of a subset as possible would be ideal.
I have a local PR that adds a few new ones (10 rules), I can update that to be just 2 rules.
That'd be great!
There was a problem hiding this comment.
I updated https://github.com/brave/adblock-lists/pull/683/files, and we would also need brave/adblock-resources#51
3 participants
For initial rollout of sugarcoat resources shipped from the CRX packager, we want to keep the resource size as small as possible while still demonstrating that the system works correctly.
This PR reduces the list of resources to just the smallest 2 (each 68060 bytes on disk when stripped of randomized padding).