Add Pay Later Button #1455
Add Pay Later Button #1455
Conversation
6c6z7ymqmk-sudo
changed the title
| <Switch | ||
| android:id="@+id/offer_pay_later_switch" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="@dimen/margin_40" | ||
| android:visibility="gone" | ||
| android:text="@string/paypal_offer_pay_later" /> |
There was a problem hiding this comment.
Would it be better to remove this Switch entirely? It doesn't look like it's ever set to visible.
There was a problem hiding this comment.
Good point. I suggest keeping this feature, as it’s still used in other places. We can add a feature switch to control the visibility of the second button I implemented, as well as this switch.
There was a problem hiding this comment.
I think with your current changes we're not able to test all of the combinations of one time checkout, billing agreement, pay later enabled, pay later disabled.
Since we're adding a dedicated button for pay later, can we add one for one time checkout and separate one for launching the billing agreement flow?
There was a problem hiding this comment.
After reviewing the codebase, Billing Agreements don’t currently support Pay Later. The first two buttons handle (1) single payments and (2) billing agreements, both with payLater = false. The newly added button handles single payments with payLater = true. This setup fulfills our current business needs.
There was a problem hiding this comment.
Got it. So it sounds like the this Switch is still not used. Can we remove it as a part of this PR?
3 participants
Thank you for your contribution to Braintree.
Summary of changes
Checklist
Screenshot
Screen_recording_20251021_143806.webm
Authors