Skip to content

fix: add thread safety primitives to internal shard list #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

braindigitalis
Copy link
Contributor

fix adds shared lock to shards list so that accessing the shards list doesnt risk crashing the lib. Has never crashed in production for me but still the issue exists and should be patched.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this May 18, 2025
Copy link

netlify bot commented May 18, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 5956fcb
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/68292d69588b800008924135
😎 Deploy Preview https://deploy-preview-1436--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels May 18, 2025
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merperson 👀

@braindigitalis braindigitalis merged commit 309772d into dev May 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants