Skip to content

misc: execute on_stop callback of all timers on bot shutdown #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

misc: execute on_stop callback of all timers on bot shutdown #1424

merged 1 commit into from
Apr 22, 2025
+7 −0

Conversation

Commandserver
Copy link
Member

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added the code Improvements or additions to code. label Apr 22, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 22, 2025 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit b3c8f2a
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/680794b4c6c0460008336576
😎 Deploy Preview https://deploy-preview-1424--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor

image

Jaskowicz1
Jaskowicz1 reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Jaskowicz1
Jaskowicz1 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve with my previous comment, smh

Mishura4
Mishura4 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see you back!

@Mishura4 Mishura4 merged commit d2810d7 into brainboxdotcc:dev Apr 22, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mishura4 Mishura4 Mishura4 approved these changes

@braindigitalis braindigitalis braindigitalis approved these changes

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

Assignees
No one assigned
Labels
code Improvements or additions to code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Commandserver @Jaskowicz1 @Mishura4 @braindigitalis