Skip to content

Conversation

@brafdlog
Copy link
Owner

@brafdlog brafdlog commented Dec 7, 2020

  • Fix hash column (the current code is fragile because it assumes the which column is the hash column. Will think of a way to make this safer)
  • Throw clear error if no sheet with the expected name exists

@brafdlog brafdlog requested a review from baruchiro December 7, 2020 20:35
@brafdlog brafdlog changed the base branch from master to unifyRepos December 7, 2020 20:35
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, no big change, but note that with the Frontend I already implemented, I have an option to create a new Spreadsheet, so of course if you're creating a new one, you will not have even the Spreadsheet.

This lead me to the open issue- #120

I don't care if you merging this, but I think it's not relevent. Unless you think otherwise so that we need to talk.

Written from Github CLI so no auto English fixes

@brafdlog
Copy link
Owner Author

OK, no big change, but note that with the Frontend I already implemented, I have an option to create a new Spreadsheet, so of course if you're creating a new one, you will not have even the Spreadsheet.

Thats true but in any case, the spreadsheet is something the user can change and if deletes/renames the sheet we will fail and I would like to get a clear error so I think it is still relevant.

@brafdlog brafdlog merged commit 01862ad into unifyRepos Dec 13, 2020
@brafdlog brafdlog deleted the sheetsFixes branch December 13, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants