[CLOSED] Locale descriptions in switching language modal.

[core-ai-bot]

Issue by tammo
Thursday May 02, 2013 at 20:16 GMT
Originally opened as adobe/brackets#3704

---

Here i take up the pull request adobe/brackets#3677.

I added english i18n for the locales and i moved them in the strings.js to the modal strings.

additional infos:
issue adobe/brackets#1461
card https://trello.com/c/Pjw3vGt2

I also removed the locale label string, because a short descriptions "feels" a lot more usable than a locale in ( ). So now there will be plain "English" instead of "en". And because of the fallback there wont be a plain locale in the modal anymore.

---

tammo included the following code: https://github.com/adobe/brackets/pull/3704/commits

[core-ai-bot]

Comment by RaymondLim
Wednesday May 08, 2013 at 23:07 GMT

---

@tammo Before we can merge your pull request, you need to sign up our CLA which is available at http://dev.brackets.io/brackets-contributor-license-agreement.html

[core-ai-bot]

Comment by RaymondLim
Wednesday May 08, 2013 at 23:09 GMT

---

Done with initial review.

[core-ai-bot]

Comment by tammo
Wednesday May 08, 2013 at 23:55 GMT

---

signing CLA ✓

[core-ai-bot]

Comment by RaymondLim
Thursday May 09, 2013 at 00:18 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by jasonsanjose
Friday May 10, 2013 at 18:34 GMT

---

Thanks@tammo. I've moved the trello card https://trello.com/c/Pjw3vGt2 to our Brackets History - Community Done list.