-
Notifications
You must be signed in to change notification settings - Fork 244
[Feature] add control for slideshow playback speed #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prevent autoclose when next image is loaded
| [ngClass]="playBackState == PlayBackStates.FastForward ? 'button-active':''" | ||
| (click)="fastForward()" | ||
| title="fast auto play"></span> | ||
| <span class="oi btn-group highlight control-button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oi only needed for the icon tag
| data-bs-auto-close="outside" | ||
| aria-controls="dropdown-basic"> | ||
| <span class="text-white pe-1">{{selectedPlayBackDuration + 's'}}</span> | ||
| <span class="oi-clock"></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the oi is needed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind. Ill fix it.
|
looks good to me. thank you for your contribution |
|
I found the design of the speed selector to be inconsistent with design of the app, so I moved to the submenu on the top. Sorry about that. Please consult next time before sending a PR. Thanks again for the contribution. |
|
Thanks for merging and fixing those things you highlighted! I had some trouble aligning the dropdown with those other buttons and 'io' added some weird position offset that affected height. Just got it to work like that, but I like the position you moved it to a lot, so doesn't really matter anymore I guess. I'm happy to contribute, this was actually my first time ever 🥳 What do you mean by 'consult first'? I thought opening a PR and an issue is just that. I do have a few improvements that I'd like to see. You removed some logic by refactoring the dropdown at a new location. Should I open separate issues for that or would you like to discuss those here and I open issues/PRs afterwards? What I'd like to re-add:
This feature was there already, but since you are using two-way-data binding now, my function that also set a cookie isn't called anymore. I have no idea why changing playback speed works while having an active slideshow running. The logic you added is also in that function and I just can't see it called anywhere and if this works, the cookie should be set aswell. Maybe you see something I don't.
Thank you for your work on this! I'm more than happy to fix those things myself and create a PR after we decided what to do |
|
Hi By consulting I meant it is better to have some back and forth mail before someone puts effort into implementing something. (I hope I did not sound harsh, that was no my intention). About the issues:
|
Resolves #570