Multiline values #74
Merged
Multiline values #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If brackets are unbalanced then the line continues on the next line. Need to merge together the values and comments.
|
I suspect the lint CI is failing because version 5.0.x of flake8 has broken reading its configuration (I think they were on 5.0.0 a month or so ago, and seem to be up to 5.0.4 already so I guess they're working hard!). I had a similar problem on another repo. I think it's OK to just ignore that failure for now, and give flake8 a bit longer to iron its bugs out. We could also pin flake8 to 4.x, but we'd just have to keep checking if they've fixed things and change it later - something to think about if it keeps being a problem for a long time IMO. |
johnomotani
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Looks good to me! Would be nice to have a test, but we don't have tests of reading a BOUT.inp at the moment, so happy to leave testing as a note on #20.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BOUT++
next(notmaster) if input values contain unbalanced brackets or parentheses ('[]' or '()') then reading continues to the next line. This allows long expressions (or lists in Hermes-3) to be spread over multiple lines.The corresponding code in BOUT++ is here: https://github.com/boutproject/BOUT-dev/blob/next/src/sys/options/options_ini.cxx#L132
Looking at this again, that line should probably be
while (count == 0)Fixes #73.