Skip to content

[Fix] Remove weakref usage in RequestSigner #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adev-code wants to merge 3 commits into from
Closed

[Fix] Remove weakref usage in RequestSigner #3590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96fe521
Remove weakref usage and revert memory test threshold
adev-code Nov 12, 2025
60316c0
Revert memory test threshold to 13MB
adev-code Nov 13, 2025
f572daf
roll back with the weakref for CI testing
adev-code Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions botocore/signers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import base64
import datetime
import json
import weakref

import botocore
import botocore.auth
Expand Down Expand Up @@ -85,8 +84,7 @@ def __init__(
self._auth_token = auth_token
self._service_id = service_id

# We need weakref to prevent leaking memory in Python 2.6 on Linux 2.6
self._event_emitter = weakref.proxy(event_emitter)
self._event_emitter = event_emitter

@property
def region_name(self):
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/leak/test_resource_leaks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ class TestDoesNotLeakMemory(BaseClientDriverTest):
# a substantial amount of time to the total test run time.
INJECT_DUMMY_CREDS = True
# We're making up numbers here, but let's say arbitrarily
# that the memory can't increase by more than 13MB.
# that the memory can't increase by more than 10MB.

# TODO: Attempt to bring this back to 10MB once Python 3.14 releases
MAX_GROWTH_BYTES = 13 * 1024 * 1024
MAX_GROWTH_BYTES = 10 * 1024 * 1024
Copy link
Contributor

@nateprewitt nateprewitt Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are two unrelated fixes, let's try to keep them in separate PRs. From the looks of it, the tests are still using elevated memory, so this change can't be done currently.

Copy link
Contributor Author

@adev-code adev-code Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks @nateprewitt 👍🏼


def test_create_single_client_memory_constant(self):
self.cmd('create_client', 's3')
Expand Down
Loading