-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix setuptools deprecation warnings in setup.py #3565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3565 +/- ##
===========================================
+ Coverage 93.13% 93.19% +0.05%
===========================================
Files 68 68
Lines 15336 15411 +75
===========================================
+ Hits 14283 14362 +79
+ Misses 1053 1049 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Register feature ids for sso related credentials
Deleting an old smoke test from this package since it has been consistently flaky. The service team confirmed this is due to a noisy neighbor.
When building botocore with
python -m build -w, setuptools generates deprecation warnings:License :: OSI Approved :: Apache Software Licenseclassifier is deprecated in favor of SPDX license expressionsbotocore.datadirectories are not included in the packages configuration, causing setuptools to warn they may be ignoredThis PR fixes setuptools deprecation warnings that appear during package building as described above.
Changes Made
License :: OSI Approved :: Apache Software Licensefrom classifierslicense="Apache-2.0"field using SPDX identifierfind_packages()withfind_namespace_packages()to properly include data-only directoriesfind_namespace_packagesTesting
python -m build -wruns without warningsResolves: #3434