Add recovery for Broadcom bcm2711 and bcm2712 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foutete
force-pushed
the
broadcom_recoveries
branch
2 times, most recently
from
890f4e6 to
f59468d
Compare
rgantois
requested changes
Aug 20, 2025
Collaborator
rgantois
left a comment
rgantois
left a comment
There was a problem hiding this comment.
Nice work! I've requested a few minor changes. You're also going to have to rebase on the latest master branch as there currently are some conflicts. It also seems like some CI tests have failed, please take a look at those as well.
Thanks!
The load_fw() function currently consistently checks the format of the requested firmware file, and emits a warning if it looks like a text file. Or, the pending snagrecover support for BCM SoCs requires loading a firmware file which is actually expected to be in text format. Thus, a non-relevant warning will be emitted in this case. Allow making this firmware file format check optional to avoid non-relevant warnings when a text format is expected. Signed-off-by: François Foltete <[email protected]>
The load_fw() function verifies if the requested firmware has a valid configuration, gets its path and loads it all in one go. Or the pending snagrecover support for BCM SoCs requires a way of resolving firmware paths without immediately loading them. To provide this feature and improve error reporting, separate getting the firmware's path and loading it into two separate functions. Signed-off-by: François Foltete <[email protected]>
Add the recovery process for broadcom SoCs bcm2711 and bcm2712.
These SoCs are used in Raspberry Pi Compute Module 4 and 5
respectively.
The recovery process is as follows:
1. Send FSBL to ROM Code
2. The FSBL functions as a file server client,
we answer its requests.
3. Voilà
Signed-off-by: François Foltete <[email protected]>
Add recovery documentation for Broadcom SoCs bcm 2711|2712. Signed-off-by: François Foltete <[email protected]>
Foutete
force-pushed
the
broadcom_recoveries
branch
from
f59468d to
2baaa31
Compare
Collaborator
|
LGTM, there's one small linter error remaining but I'll handle that one separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for Broadcom SoC's bcm2711 and bcm2712 in snagrecover.
It has been developed and tested using Raspberry Pi CM4 and CM5.
I use
pyfatfspython module so I added it to the project dependencies.