[FE] [06-04] 별 클릭시 해당 방향으로 카메라 시점 이동하도록 설정 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2023 20:38
- 기존에 저장되지 않던 은하의 별들에 관한 정보를 useMemo를 통해 기억하도록 했다.
- 기존에 직선으로 움직이던 카메라 움직임을 좀 더 자연스럽게 포물선을 그리며 움직이도록 개선했다. - 카메라와 currentView 사이의 거리를 distance 만큼으로 유지하도록 개선했다.
- 카메라와 물체의 최소 거리를 상수 처리했다.
- 기존에 일반 함수를 함수 선언식으로 선언 했던 것을 화살표 함수로 바꿔 주었다. - 의미가 직관적이지 않았던 distance 전역환경변수를 cameraToCurrentView로 바꿔주었다.
MinboyKim
approved these changes
Nov 16, 2023
Member
MinboyKim
left a comment
MinboyKim
left a comment
There was a problem hiding this comment.
LGTM 🐧 고생많으셨습니다!! 변경 커밋후엔 re-request review 부탁드려욤
Collaborator
|
와 너무 신기하다 최고 최고 |
2 tasks
KimGaeun0806
approved these changes
Nov 16, 2023
| setCurrentView: (position: THREE.Vector3) => set({ currentView: position }), | ||
| targetView: null, | ||
| setTargetView: (star: THREE.Mesh | null) => set({ targetView: star }), | ||
| cameraToCurrentView: CAMERA_MIN_DISTANCE, |
Member
There was a problem hiding this comment.
뭔가 camera에서 CurrentView로 이동해야할 것만 같은 이름인데..
더 좋은 네이밍이 있을 것 같은데 저도 마땅한게 안떠오르네요
DistanceBetweenAandB 형식으로 하면 너무 길 것 같은디..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📎 이슈번호
#41
📃 변경사항
📌 중점적으로 볼 부분
🎇 동작 화면
2023-11-16.8.49.24.mov
💫 기타사항