Move to new ICU4X arithmetic code #595
Merged
+150
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Manishearth
force-pushed
the
arithmetic
branch
from
9477cca to
49bd248
Compare
Manishearth
added a commit
that referenced
this pull request
Oct 9, 2025
Clean up things that would otherwise need to be addressed in #595
Manishearth
force-pushed
the
arithmetic
branch
from
49bd248 to
81b26bf
Compare
Change-Id: I6a6a69648514aad5332958b4ea5f07a6e4f577dd
Manishearth
force-pushed
the
arithmetic
branch
from
81b26bf to
e892b62
Compare
Manishearth
changed the title
|
Note: this is currently a doc(hidden) API. Hopefully we can graduate it before ICU4X 2.1, but if not, we may need to have a stronger version-locked dependency on ICU4X. That's fine IMO, it will certainly be resolved by 2.2. |
nekevss
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on unicode-org/icu4x#7012