-
-
Notifications
You must be signed in to change notification settings - Fork 304
enable sonatype deployments #6738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Peter Kirschner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a minor comment regarding .tostring().
There might be other possible cleanups here and there but still something we can discuss in the future.
| if (mbr.toString() | ||
| .contains("/sonatype_")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something to improve in the future, as relying on .toString() might be fragile.
|
related #5156 org.bndtools.p2: Update the build for the p2 repository to replace md5 checksum and
source: #5156 (comment) |
| private boolean isSonatypeCentralPortal(String releaseUrl) { | ||
| if (releaseUrl == null) | ||
| return false; | ||
| return releaseUrl.contains("central.sonatype.com/api/v1/publisher/upload/"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, if its a good idea to depend this feature on a fixed URL. If we would update our Sonatype Nexus to the latest version, we would also get the new release process. But then the repository would only work for this URL but not ours. Wouldn't it be better to use a flag on the repository configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with nexus installations (is it available as OSS installation). My assumption was that only sonatype is using this new api for deployments.
Are you using a nexus server? Do you have more references on nexus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonatype Nexus is a product, like artifactory is. We run the previous version on our infrastructure, the Eclipse Foundation runs an own instance (also still an older version). The new version will use the same API like for maven central. But the URL's are then different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterkir can you make this fixed URL overwritable by configuration property. Having this as the default seems okay to me, but it would be nice to be able to overwrite it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I there any documentation on how to use this? Maybe in the ticket?
|
@peterkir Have you been able to work on what we discussed a while back? |
enable releae to sonatype / maven-central via
https://central.sonatype.com/api/v1/publisher/upload
as documented here
https://central.sonatype.org/publish/publish-portal-api/#uploading-a-deployment-bundle