Skip to content

Conversation

@peterkir
Copy link
Contributor

@peterkir peterkir commented Aug 4, 2025

Signed-off-by: Peter Kirschner <[email protected]>
@stbischof
Copy link
Contributor

@maho7791
@juergen-albert

Copy link
Contributor

@chrisrueger chrisrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor comment regarding .tostring().
There might be other possible cleanups here and there but still something we can discuss in the future.

Comment on lines +93 to +94
if (mbr.toString()
.contains("/sonatype_")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something to improve in the future, as relying on .toString() might be fragile.

@chrisrueger
Copy link
Contributor

chrisrueger commented Aug 22, 2025

related #5156 org.bndtools.p2: Update the build for the p2 repository to replace md5 checksum

and

We also need to support the PGP signing recently added to eclipse. See https://gitlab.eclipse.org/eclipse-wg/ide-wg/community/-/issues/11#downstream-product-considerations.

source: #5156 (comment)

private boolean isSonatypeCentralPortal(String releaseUrl) {
if (releaseUrl == null)
return false;
return releaseUrl.contains("central.sonatype.com/api/v1/publisher/upload/");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, if its a good idea to depend this feature on a fixed URL. If we would update our Sonatype Nexus to the latest version, we would also get the new release process. But then the repository would only work for this URL but not ours. Wouldn't it be better to use a flag on the repository configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with nexus installations (is it available as OSS installation). My assumption was that only sonatype is using this new api for deployments.
Are you using a nexus server? Do you have more references on nexus?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonatype Nexus is a product, like artifactory is. We run the previous version on our infrastructure, the Eclipse Foundation runs an own instance (also still an older version). The new version will use the same API like for maven central. But the URL's are then different.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterkir can you make this fixed URL overwritable by configuration property. Having this as the default seems okay to me, but it would be nice to be able to overwrite it.

Copy link
Contributor

@maho7791 maho7791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I there any documentation on how to use this? Maybe in the ticket?

@juergen-albert
Copy link
Contributor

@peterkir Have you been able to work on what we discussed a while back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants