Skip to content

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Apr 8, 2022

this redirects 192.168.2.2:2770 to 192.168.2.2.
ideally we should redirect it to "blueos.local" or whatever the current name is, but I don't think we can fetch that name from nginx yet...

We could use beacon in the frontend to choose a domain and redirect to it

fix #632

@patrickelectric
Copy link
Member

this redirects 192.168.2.2:2770 to 192.168.2.2. ideally we should redirect it to "blueos.local" or whatever the current name is, but I don't think we can fetch that name from nginx yet...

We could use beacon in the frontend to choose a domain and redirect to it

fix #632

Will this break companion.local ?

@Williangalvani
Copy link
Member Author

this redirects 192.168.2.2:2770 to 192.168.2.2. ideally we should redirect it to "blueos.local" or whatever the current name is, but I don't think we can fetch that name from nginx yet...
We could use beacon in the frontend to choose a domain and redirect to it
fix #632

Will this break companion.local ?

nah, this only makes anything on port 2770 to the same thing at port 80
the previous patch that changed this line was probably a mistake. as it made 192.168.2.2:2770 redirect to http://(blueos|companion).local which isn't valid at all (see related issue)

@patrickelectric patrickelectric merged commit fb72174 into bluerobotics:master Apr 8, 2022
@Williangalvani Williangalvani deleted the redirect branch April 8, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: nginx: consider serving the web interface at :2770, or at least redirect it to :80
2 participants