Create mavlink-inspector #794
Conversation
Williangalvani
force-pushed
the
mavlink-inspector
branch
from
76ed306 to
f68a70f
Compare
Williangalvani
changed the title
Williangalvani
requested review from
rafaellehmkuhl,
patrickelectric and
ES-Alexander
|
While this is not 100% ready, I think it is good and useful enough to go in as is, I intend to keep working on it with time, adding things like live plotting |
There was a problem hiding this comment.
I'm a fan - nice work! :-)
I reckon it would be useful to include the timestamps in the main list display of the messages, but that can be added later (and was that the thing that needed to be fixed in mavlink2rest first or something?)
Agreed that it's useful enough as-is that it's worth making available now, and improving as you/we have time later :-)
| @@ -0,0 +1,33 @@ | |||
| export default function prettify(message: any): string { | |||
| if (message.type === 'STATUSTEXT') { | |||
There was a problem hiding this comment.
Is there a problem to use switch case here ?
There is also the possibility yo create a Map<String, closure> to make the code more encapsulated, but both alternatives should work.
core/frontend/src/components/mavlink-inspector/MavlinkInspector.vue
Outdated
Show resolved
Hide resolved
Williangalvani
force-pushed
the
mavlink-inspector
branch
from
f68a70f to
df03954
Compare
Williangalvani
force-pushed
the
mavlink-inspector
branch
from
df03954 to
19a222e
Compare
it needs a new icon and probably some comments in the code before it is ready to go in.
Them, later on, it should be upgraded to support plotting stuff.
Image is up at williangalvani/companion-core:mavlinkinspector