Skip to content

Conversation

@joaomariolago
Copy link
Collaborator

@joaomariolago joaomariolago commented Oct 23, 2025

Closes #1705

  • Make sure the connect to internet banner only appears when no internet connection is available instead of WiFi network

Summary by Sourcery

Use the app’s internet connectivity status instead of WiFi network presence to control the “connect to internet” alert in MainView.vue.

Bug Fixes:

  • Show the connection banner only when there is no internet connection rather than when not connected to a WiFi network.

Enhancements:

  • Replace the current_network computed property with has_internet using helper.has_internet and InternetConnectionState.
  • Update imports to remove WiFi store and include helper module and its types.

* Make sure the connect to internet banner only appears when no internet
  connection is available instead of WiFi network
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR refactors MainView to use a dedicated internet connectivity state instead of the WiFi network presence for showing the connect-to-internet banner, updating imports and the computed property accordingly.

Class diagram for updated connectivity check in MainView.vue

classDiagram
    class MainView {
        <<VueComponent>>
        +has_internet: boolean
        +orientation: string
    }
    class helper {
        +has_internet: boolean
    }
    class InternetConnectionState {
        <<enum>>
        +OFFLINE
        +ONLINE
    }
    MainView --> helper : uses
    MainView --> InternetConnectionState : uses
Loading

File-Level Changes

Change Details Files
Switch banner display to use internet connectivity status
  • Changed v-if on the alert from !current_network to !has_internet
  • Replaced current_network computed property with has_internet logic using helper.has_internet
  • Compared helper.has_internet against InternetConnectionState.OFFLINE
core/frontend/src/views/MainView.vue
Adjust imports to support internet connectivity check
  • Imported helper store and InternetConnectionState enum
  • Removed wifi store and Network type imports
core/frontend/src/views/MainView.vue

Assessment against linked issues

Issue Objective Addressed Explanation
#1705 Change the welcome banner logic to check for internet connection status instead of WiFi connection status.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@joaomariolago joaomariolago marked this pull request as ready for review October 23, 2025 19:26
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit 1a446f3 into bluerobotics:master Oct 23, 2025
7 checks passed
@patrickelectric patrickelectric added the move-to-stable Needs to be cherry-picked and move to stable label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

move-to-stable Needs to be cherry-picked and move to stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Welcome banner should check for internet connection instead of wifi connection

2 participants