Frontend: InlineParameterEditor: make parameters value update when dr…

[joaoantoniocardoso]

This is a backport of #3441 into 1.4

Summary by Sourcery

Bug Fixes:

• Use String() instead of toString() to update internal_new_value_as_string after internal_new_value is set on prop change and reset.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backport #3441 into v1.4 by updating InlineParameterEditor to consistently derive the internal string value via String() conversion and ensure initial string state is set when the component initializes.

Class diagram for updated InlineParameterEditor component

classDiagram
    class InlineParameterEditor {
        - param
        - internal_new_value
        - internal_new_value_as_string
        - last_sent_value
        - param_value
        + watch: param(newParam)
        + watch: is_form_valid(valid)
        + mounted()
        + updateSelectedFlags()
    }
    InlineParameterEditor : param(newParam) sets internal_new_value and internal_new_value_as_string using String()
    InlineParameterEditor : mounted() sets internal_new_value and internal_new_value_as_string using String() if last_sent_value is undefined

Loading

File-Level Changes

Change	Details	Files
Switch value-to-string conversion to use String()	Replaced .toString() with String() when updating internal_new_value_as_string in the param watcher	core/frontend/src/components/parameter-editor/InlineParameterEditor.vue
Initialize the string representation on first render	Added assignment of internal_new_value_as_string = String(this.internal_new_value) when last_sent_value is undefined	core/frontend/src/components/parameter-editor/InlineParameterEditor.vue

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @joaoantoniocardoso - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}