core: frontend: VideoStreamCreationDialog: use even default UDP ports

[joaoantoniocardoso]

This is a backport of #3375 into 1.4

Summary by Sourcery

Enhancements:

• Use even default UDP ports for VideoStreamCreationDialog by adjusting the port calculation for UDP and UDP265 streams.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backport of PR #3375 to version 1.4 that updates the VideoStreamCreationDialog to calculate default UDP and UDP265 ports as even offsets.

Class diagram for VideoStreamCreationDialog default port logic update

classDiagram
    class VideoStreamCreationDialog {
        +Array stream_endpoints
        +String user_ip_address
        +void setDefaultEndpoint(index, StreamType)
    }
    class StreamType {
        <<enumeration>>
        UDP
        UDP265
        RTSP
    }
    VideoStreamCreationDialog --> StreamType

    %% Highlight the updated logic for UDP and UDP265
    note for VideoStreamCreationDialog "
    setDefaultEndpoint(index, StreamType):
      if StreamType == UDP or UDP265:
        endpoint = protocol + '://' + user_ip_address + ':' + (5600 + 2 * index)
    "

Loading

File-Level Changes

Change	Details	Files
Use even port offsets for default UDP streams	Changed default UDP port calculation from 5600+index to 5600+2index Changed default UDP265 port calculation from 5600+index to 5600+2index	core/frontend/src/components/video-manager/VideoStreamCreationDialog.vue

Possibly linked issues

• #0: The PR changes default UDP/UDP265 port assignment to prevent conflicts, addressing the issue's port conflict problem.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @joaoantoniocardoso - I've reviewed your changes - here's some feedback:

• Consider extracting the default UDP port base (5600) and the multiplier (2) into named constants to avoid magic numbers and improve readability.
• The UDP and UDP265 case blocks contain nearly identical logic—refactor the endpoint-generation into a shared helper to reduce duplication.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider extracting the default UDP port base (5600) and the multiplier (2) into named constants to avoid magic numbers and improve readability.
- The UDP and UDP265 case blocks contain nearly identical logic—refactor the endpoint-generation into a shared helper to reduce duplication.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}