Skip to content

core: tools: Move mavlink-camera-manager from install-system-tools to install-static-tools #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jul 15, 2025

Signed-off-by: Patrick José Pereira [email protected]

Summary by Sourcery

Relocate mavlink-camera-manager from the system tools installer to the static tools installer and update the Dockerfile accordingly.

Enhancements:

  • Move mavlink-camera-manager entry from install-system-tools.sh to install-static-binaries.sh
  • Include mavlink-camera-manager in the static tools list for installation

Build:

  • Add mavlink-camera-manager to the Dockerfile copy directive for static tools

Copy link

sourcery-ai bot commented Jul 15, 2025

Reviewer's Guide

Relocate the mavlink-camera-manager tool from system to static installation by updating Dockerfile and installer scripts accordingly.

Flow diagram for mavlink-camera-manager installation process change

flowchart TD
    A[Start: Install Tools] --> B{Is tool in system tools?}
    B -- Yes --> C[Install via install-system-tools.sh]
    B -- No --> D{Is tool in static tools?}
    D -- Yes --> E[Install via install-static-binaries.sh]
    D -- No --> F[Skip]
    C --> G[Done]
    E --> G
    F --> G
    %% Change: mavlink-camera-manager now follows the static tools path
Loading

File-Level Changes

Change Details Files
Include mavlink-camera-manager in static tools copy
  • Added /usr/bin/mavlink-camera-manager to the COPY command
core/Dockerfile
Register mavlink_camera_manager in static binaries installer
  • Added mavlink_camera_manager to the TOOLS array
core/tools/install-static-binaries.sh
Remove mavlink_camera_manager from system tools installer
  • Removed mavlink_camera_manager from the TOOLS array
core/tools/install-system-tools.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patrickelectric - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joaoantoniocardoso joaoantoniocardoso merged commit 5c713ec into bluerobotics:master Jul 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants