autopilot manager: fix auto_restart_autopilot() race condition

[Williangalvani]

fix #3400

needs testing tested by @vshie

Summary by Sourcery

Bug Fixes:

• Catch psutil.NoSuchProcess in is_ardupilot_process to avoid race condition when inspecting process cmdline.

Summary by Sourcery

Bug Fixes:

• Catch psutil.NoSuchProcess exceptions in is_ardupilot_process to prevent failures when a process ends before cmdline() is called.

[sourcery-ai]

Reviewer's Guide

Wrapped the process cmdline lookup in a try/except block to catch and ignore psutil.NoSuchProcess errors, preventing race conditions when inspecting terminated processes.

Class diagram for updated is_ardupilot_process function

classDiagram
    class AutopilotManager {
        +is_ardupilot_process(process: psutil.Process) bool
    }
    class psutil_Process {
        +cmdline() list
    }
    AutopilotManager --|> psutil_Process : uses
    AutopilotManager : +try/except psutil.NoSuchProcess
    AutopilotManager : +ignore process if NoSuchProcess

Loading

File-Level Changes

Change	Details	Files
Add exception handling around cmdline inspection to avoid racing on process exit	Wrap firmware_path string check in a try/except Catch psutil.NoSuchProcess and silently continue	core/services/ardupilot_manager/autopilot_manager.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation

Possibly linked issues

• [autopilot-manager] Race condition at auto_restart_ardupilot() #3400: The PR fixes the race condition by catching psutil.NoSuchProcess when calling process.cmdline(), directly addressing the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Williangalvani - I've reviewed your changes - here's some feedback:

• Consider logging the caught NoSuchProcess at debug level so you can monitor how often this race condition occurs.
• You could use psutil.process_iter(attrs=['cmdline']) to fetch cmdline in bulk and shrink the race window instead of calling process.cmdline() per process.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider logging the caught NoSuchProcess at debug level so you can monitor how often this race condition occurs.
- You could use psutil.process_iter(attrs=['cmdline']) to fetch cmdline in bulk and shrink the race window instead of calling process.cmdline() per process.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[patrickelectric]

so.. shouldn't this check for is_running ?

[Williangalvani]

yes that should work! will need re-testing though

[Williangalvani]

hmmm there would still be a chance, though. of the process stopping existing between the is_running() check and the cmdline() call.